Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: added paths-ignore to e2e-wasm #6340

Merged
merged 2 commits into from
May 21, 2024
Merged

ci: added paths-ignore to e2e-wasm #6340

merged 2 commits into from
May 21, 2024

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented May 20, 2024 •
edited by coderabbitai bot
Loading

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated workflow to exclude triggering on changes to docs/, Markdown files, and the LICENSE file.

@srdtrk srdtrk added the github_actions Pull requests that update Github_actions code label May 20, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 20, 2024 •
edited
Loading

Walkthrough

Walkthrough

The .github/workflows/e2e-wasm.yaml file was updated to exclude certain paths and files from triggering the workflow. Specifically, changes in the docs/ directory, Markdown files (**.md), and the LICENSE file will no longer trigger the workflow. This adjustment helps optimize the workflow by ignoring non-essential changes.

Changes

File Path Change Summary
.github/workflows/e2e-wasm.yaml Added exclusions for docs/ directory, Markdown files (**.md), and LICENSE file in workflow triggers.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

DimitrisJim
DimitrisJim approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

chatton
chatton approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

coderabbitai[bot]
coderabbitai bot reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 56ae97d and 519538c.
Files selected for processing (1)
  • .github/workflows/e2e-wasm.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/e2e-wasm.yaml

@srdtrk srdtrk merged commit 7e70179 into main May 21, 2024
74 checks passed
@srdtrk srdtrk deleted the serdar/xxx-ci-wasm-ignore branch May 21, 2024 09:48
DimitrisJim
DimitrisJim reviewed May 21, 2024
View reviewed changes
.github/workflows/e2e-wasm.yaml
@@ -16,7 +16,10 @@ on:
- synchronize
# trigger workflow if PR is marked ready for review.
- ready_for_review

paths-ignore:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen a warning pop-up when merging main to ics20v2 (same warning was present for this PR https://github.com/cosmos/ibc-go/actions/runs/9172311273/workflow)

wonder if the paths globs can actually just match on any *.go files (though dunno if github syntax here can do this) or if we can use negations for other file types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@chatton chatton chatton approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srdtrk @chatton @DimitrisJim